-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requests for missing favicon.ico cause dash's index route to be served #152
Comments
I like the idea of having a default favicon, maybe the Dash logo? Or we can just add a default route for |
Yeah, I like the idea of a built-in Dash favicon too. |
I think including a default dash |
Here are some favicons we could use |
I will add the |
Replace all instances of plot.ly with plotly.com.
Replace all instances of plot.ly with plotly.com.
I just noticed that when a favicon is not wired up, the automatic request for
/favicon.ico
by the browser results in the dash server returning its index route. This seems to be a consequence of there being a catchall redirecting all URLs that are not matched to the index route.While probably not too harmful, this seems undesirable. One solution could be to include a default favicon, but perhaps it is also worth establishing whether the catchall behaviour is desirable?
The text was updated successfully, but these errors were encountered: