Add ability to turn off zodb-temporary-storage to prevent Zope 4 breakage
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dataflake thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
gforcada
approved these changes
Apr 20, 2019
mauritsvanrees
added a commit
that referenced
this pull request
Jan 12, 2021
You used to be able to set `zodb-temporary-storage = <some config />` and have this config in the `site.zcml`. Most important use of this was to let this empty, effectively disabling the temporary storage. PR #93 changed this so you could do this in a more natural way. by setting `zodb-temporary-storage = false`. But this (accidentally) removed the possibility for setting an explicit own version of the temporary storage snippet, and meant the only options now were false or true. The documentation still mentions: If given Zope's default temporary storage definition will be replaced by the lines of this parameter.
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Jan 18, 2021
Branch: refs/heads/master Date: 2021-01-12T15:46:44+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.recipe.zope2instance@8b15c68 Restored ability to use own explicit version of zodb-temporary-storage. You used to be able to set `zodb-temporary-storage = <some config />` and have this config in the `site.zcml`. Most important use of this was to let this empty, effectively disabling the temporary storage. PR plone/plone.recipe.zope2instance#93 changed this so you could do this in a more natural way. by setting `zodb-temporary-storage = false`. But this (accidentally) removed the possibility for setting an explicit own version of the temporary storage snippet, and meant the only options now were false or true. The documentation still mentions: If given Zope's default temporary storage definition will be replaced by the lines of this parameter. Files changed: A news/93.bugfix M src/plone/recipe/zope2instance/recipe.py Repository: plone.recipe.zope2instance Branch: refs/heads/master Date: 2021-01-13T11:47:11+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.recipe.zope2instance@8179b10 Added more tests for zodb-temporary-storage option. They fail without the fix from the previous commit. Files changed: M src/plone/recipe/zope2instance/tests/zope2instance_tempstorage_off.rst Repository: plone.recipe.zope2instance Branch: refs/heads/master Date: 2021-01-18T12:31:15+01:00 Author: Maurits van Rees (mauritsvanrees) <m.van.rees@zestsoftware.nl> Commit: plone/plone.recipe.zope2instance@d1f8785 Merge pull request #160 from plone/maurits/fix-explicit-zodb-temporary-storage Restored ability to use own explicit version of zodb-temporary-storage. Files changed: A news/93.bugfix M src/plone/recipe/zope2instance/recipe.py M src/plone/recipe/zope2instance/tests/zope2instance_tempstorage_off.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87
I have changed the allowed input values for
zodb-temporary-storageso it can be turned off explicitly by passing something likeofforfalse. The existing semantic of "add this but leave it empty" is non-obvious and odd.I have called this a bug because it breaks basic Zope 4 startup right now.
My original plan of trying to peek into the resolved set of requirements and find
Products.TemporaryFolderseemed too hard in this place of the code.I want to use this flag (and the changes from my previous PRs) in my Zope installation documentation rewrite where I am featuring
plone.recipe.zope2instanceas the most convenient way of installing and configuring Zope, so I would like to ask for a release from you when this is merged.See https://zope.readthedocs.io/en/latest/INSTALL.html and https://zope.readthedocs.io/en/latest/operation.html for the current documentation status.