Restored ability to use own explicit version of zodb-temporary-storage. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You used to be able to set `zodb-temporary-storage = <some config />` and have this config in the `site.zcml`. Most important use of this was to let this empty, effectively disabling the temporary storage. PR #93 changed this so you could do this in a more natural way. by setting `zodb-temporary-storage = false`. But this (accidentally) removed the possibility for setting an explicit own version of the temporary storage snippet, and meant the only options now were false or true. The documentation still mentions: If given Zope's default temporary storage definition will be replaced by the lines of this parameter.
This comment has been minimized.
This comment has been minimized.
|
Note: no Jenkins jobs needed, because Jenkins does not run our tests. |
They fail without the fix from the previous commit.
That may be good, yes. I have added two tests now. |
mauritsvanrees
deleted the
maurits/fix-explicit-zodb-temporary-storage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You used to be able to set
zodb-temporary-storage = <some config />and have this config in thesite.zcml.Most important use of this was to let this empty, effectively disabling the temporary storage.
PR #93 changed this so you could do this in a more natural way, by setting
zodb-temporary-storage = false.But this (accidentally) removed the possibility for setting an explicit own version of the temporary storage snippet, and meant the only options now were false or true.
The documentation still mentions: