Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #313 - Fix tests to match plone.dexterity dynamic schema name #314

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Refs #313 - Fix tests to match plone.dexterity dynamic schema name #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3da50e
Refs #313 - Fix tests to match plone.dexterity dynamic schema name
avoinea Oct 5, 2020
e7fbd5f
Cleanup unused schema in tests
avoinea Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/313.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Update tests to fix https://github.com/plone/plone.dexterity/pull/137
[@avoinea]
2 changes: 1 addition & 1 deletion plone/app/dexterity/tests/editing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ and saved::
>>> from plone.i18n.normalizer.interfaces import IIDNormalizer
>>> from plone.schemaeditor import interfaces
>>> normalizer = component.getUtility(IIDNormalizer)
>>> schema = plonista.lookupSchema()
>>> for name, factory in sorted(component.getUtilitiesFor(
... interfaces.IFieldFactory)):
... if hasattr(factory, 'protected') and factory.protected(None):
Expand All @@ -129,6 +128,7 @@ and saved::
... browser.getControl('Field type').getControl(
... value=factory.title).selected = True
... browser.getControl('Add').click()
... schema = plonista.lookupSchema()
avoinea marked this conversation as resolved.
Show resolved Hide resolved
... assert browser.url == "http://nohost/plone/dexterity-types/plonista/@@add-field", (
... "Couldn't successfully add %r" % name)
... assert field_id in schema, '%r not in %r' % (
Expand Down