Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #313 - Fix tests to match plone.dexterity dynamic schema name #314

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

avoinea
Copy link
Member

@avoinea avoinea commented Oct 5, 2020

Fixes #313

@mister-roboto
Copy link

@avoinea thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@avoinea
Copy link
Member Author

avoinea commented Oct 5, 2020

@jenkins-plone-org please run jobs

Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just added a clean up suggestion

@ale-rt
Copy link
Member

ale-rt commented Oct 5, 2020

@jenkins-plone-org please run jobs

@ale-rt ale-rt merged commit f1862db into master Oct 5, 2020
@ale-rt ale-rt deleted the sync-schema-on-zeo-clients branch October 5, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests to match plone.dexterity changes
3 participants