Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass default_page_types to allow respecting that in folder_contents #208

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

pbauer
Copy link
Sponsor Member

@pbauer pbauer commented Jul 30, 2020

Required for plone/mockup#1005

@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@pbauer
Copy link
Sponsor Member Author

pbauer commented Jul 30, 2020

@jenkins-plone-org please run jobs

Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbauer pbauer merged commit dbecd6f into master Jul 31, 2020
pbauer added a commit that referenced this pull request Aug 6, 2020
pbauer added a commit that referenced this pull request Aug 6, 2020
@pbauer pbauer deleted the fix_default_page_types_in_folder_contents branch August 6, 2020 11:45
mister-roboto pushed a commit to plone/buildout.coredev that referenced this pull request Aug 6, 2020
Branch: refs/heads/3.5.x
Date: 2020-08-06T09:37:01+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.content@a3121bb

backport plone/plone.app.content#208

Files changed:
M plone/app/content/browser/contents/__init__.py
Repository: plone.app.content

Branch: refs/heads/3.5.x
Date: 2020-08-06T09:49:54+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.content@68a4ffc

add changenote

Files changed:
A news/209.bugfix
Repository: plone.app.content

Branch: refs/heads/3.5.x
Date: 2020-08-06T09:50:41+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.content@cb92221

Merge branch '3.5.x' into backport_208

Files changed:

Repository: plone.app.content

Branch: refs/heads/3.5.x
Date: 2020-08-06T13:44:49+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.content@feaac34

Merge pull request #209 from plone/backport_208

backport plone/plone.app.content#208

Files changed:
M news/209.bugfix
M plone/app/content/browser/contents/__init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants