respect default_page_types in actionmenu if folder_contents

[pbauer]

Fixes plone/Products.CMFPlone#2700
Together with plone/plone.app.content#208

[mister-roboto]

@pbauer thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

[pbauer]

@jenkins-plone-org please run jobs

[ale-rt]

LGTM

[pbauer]

I'm not sure why travis fails with:

undefined is not an object (evaluating 'app.defaultPageTypes.indexOf')

Could it be that the build requires the source-checkout of plone.app.content or did I miss something when writing the code? It worked fine locally.

Also: Once this is merged plone.staticresources needs to be added to checkouts.cfg of coredev? Do I need to do all the other things it says in https://github.com/plone/plone.staticresources/#how-to-upgrade-the-resources-in-this-package?

[vincentfretin]

The mockup tests doesn't depends on Plone, do a search for the failing test "use special view action for special types". The test is defined in mockup/tests/pattern-structure-test.js. You may need to add defaultPageTypes to the mock defined there.
Travis actually seems to test only with PhantomJS 8 times. :) Please test with the make test command (PhantomJS) and then with make test-dev (Chrome) locally. Both are green in master.

Yes you need to do all the things described in https://github.com/plone/plone.staticresources/#how-to-upgrade-the-resources-in-this-package and you need to checkout plone.staticresources yes like the documentation says. I updated it recently when I did the last upgrade step, I hope the instructions are clear.

[pbauer]

@vincentfretin thanks for the info. I fixed the tests and will now proceed to follow your docs 😄