Revert enabling image bitmap #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR removes support for WebGPU, which it should not. |
Webgp.. what? :D Thanks - fixed! |
mvaligursky
approved these changes
Aug 30, 2022
GSterbrant
pushed a commit
that referenced
this pull request
Aug 30, 2022
* revert enabling image bitmap * add note about space base * enable under webgpu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #4584.
After doing some testing it seems ImageBitmap is still not well supported across browsers. Details have been left in the code for next time.
It might be worth investigating more closely which browsers have concrete support for ImageBitmap and start selectively enabling the interface on those browsers.