Enable ImageBitmap if interface is present #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any concerns on older browses? For example:
|
Nope. That was an issue with 'flipY' option which we no longer need. |
|
Think I will try find an old version of firefox to test on though. |
mvaligursky
reviewed
Aug 23, 2022
mvaligursky
reviewed
Aug 23, 2022
mvaligursky
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we no longer flip images at load time in the engine (#3335) we can use ImageBitmap for loading images.
ImageBitmap performs more work off the main thread and should result in much smoother experiences for our users.
This PR was tested on a recent version of Chrome, Safari and Firefox.