Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Check _flipFaces on camera not camera component #3352

Merged
merged 1 commit into from
Jul 21, 2021
Merged

[FIX] Check _flipFaces on camera not camera component #3352

merged 1 commit into from
Jul 21, 2021

Conversation

slimbuck
Copy link
Member

Error introduced in #3346

@slimbuck slimbuck added bug area: graphics Graphics related issue labels Jul 21, 2021
@slimbuck slimbuck requested a review from a team July 21, 2021 11:11
@slimbuck slimbuck self-assigned this Jul 21, 2021
@yaustar
Copy link
Contributor

yaustar commented Jul 21, 2021

Should we rename camera to cameraComponent?

@slimbuck
Copy link
Member Author

Should we rename camera to cameraComponent?

Maybe some other time :)

yaustar
yaustar approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@yaustar yaustar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Comment previously provided 'Should we rename camera to cameraComponent'

@slimbuck slimbuck merged commit 5897fd3 into playcanvas:master Jul 21, 2021
@slimbuck slimbuck deleted the flipfaces-fix branch July 21, 2021 11:16
@yaustar
Copy link
Contributor

yaustar commented Jul 21, 2021 •
edited
Loading

Should we rename camera to cameraComponent?

Maybe some other time :)

Would we hit the same issue next time though as well? It's only because I double check potential tutorial projects that may be affected by render textures that we found this.

@willeastcott
Copy link
Contributor

We should add that project to the test plan. 😄

@slimbuck
Copy link
Member Author

We should add that project to the test plan. 😄

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaustar yaustar yaustar approved these changes

Assignees

@slimbuck slimbuck

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slimbuck @yaustar @willeastcott