Add text body to all emails #4262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
force-pushed
the
add-text-body-to-all-emails
branch
4 times, most recently
from
8df1c56
to
72291ca
Compare
ruslandoga
force-pushed
the
add-text-body-to-all-emails
branch
from
39a1b80
to
0ec1c6b
Compare
2 tasks
aerosol
approved these changes
Jun 24, 2024
| @@ -102,7 +102,7 @@ defmodule Plausible.Imported.Importer do | |||
|
|
|||
| @callback name() :: atom() | |||
| @callback label() :: String.t() | |||
| @callback email_template() :: String.t() | |||
| @callback email_template() :: atom | String.t() | |||
There was a problem hiding this comment.
Right now, yes. But I thought we could still allow strings as well since they are accepted by Bamboo's render function.
|
Hmm I'm not a fan of having to maintain two sets of email templates.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #4249
Tests
Changelog
Documentation
Dark mode