Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We can now check for all the poses required #18

Merged
merged 12 commits into from
May 30, 2024
Merged

We can now check for all the poses required #18

merged 12 commits into from
May 30, 2024

Conversation

pkg-dot-zip
Copy link
Owner

Note: This pull request is just so that you guys have the updated code. Although it is fully functional, I will refactor and tweak it slightly tonight or tomorrow.

Eyo peeps, check this out:

  • Finished the pose estimation system.
  • Implemented some unit tests for the pose estimation system.

This code still needs to be cleaned up.

TODO For me:

  • Add more comments explaining code.
  • Rename constants and settings to have more fitting descriptions.
  • Exception handling -> What if user doesn't have a camera? What if the models are not set in the correct folder?
  • More unit tests.

@pkg-dot-zip pkg-dot-zip self-assigned this May 30, 2024
Sam-D-C
Sam-D-C approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@Sam-D-C Sam-D-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, well done

Mosu5
Mosu5 approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@Mosu5 Mosu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkg-dot-zip pkg-dot-zip merged commit ca313ec into dev May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mosu5 Mosu5 Mosu5 approved these changes

@Sam-D-C Sam-D-C Sam-D-C approved these changes

Assignees

@pkg-dot-zip pkg-dot-zip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkg-dot-zip @Mosu5 @Sam-D-C