Clean up 🧹 #11
Merged
Clean up 🧹 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
pkg-dot-zip
commented
May 13, 2024
pkg-dot-zip
commented
- Changed default (de)constructors to actual "default" (de)constructor.
- Removed some unneeded whitespaces.
- Changed parameter names to "deltaTime" where appropriate.
- Changed resolution of window to 1600x900.
- Refactored initialization of different libraries and parts of the software into own methods.
- Moved deinitialization code to onDestroy() method.
- Removed unused variable.
- Capitalized uncapitalized comments.
- Now call the setup for the logger again.
- Fixed naming for the log files in the log/ folder.
- Log entry for all inits & the onDestroy() method.
- Made default params for Spin & Cube components.
added 4 commits
May 13, 2024 16:04
- Changed default (de)constructors to actual "default" (de)constructor. - Removed some unneeded whitespaces. - Changed parameter names to "deltaTime" where appropriate.
- Changed resolution of window to 1600x900. - Refactored initialization of different libraries and parts of the software into own methods. - Moved deinitialization code to onDestroy() method. - Removed unused variable. - Capitalized uncapitalized comments.
- Now call the setup for the logger again. - Fixed naming for the log files in the log/ folder. - Log entry for all inits & the onDestroy() method.
|
LGTM! Goede structuur en duidelijke comments👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.