Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ragex check added on subdomain #83

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

GautamGoyal2341
Copy link
Contributor

What does this PR do?

"This PR introduces validation for the subdomain field in the ProjectModal component. It ensures that the subdomain input can only contain plain text without spaces or special characters. The validation is applied using a regex pattern, and an appropriate error message is displayed to the user if the input does not meet the criteria. This enhancement improves the user experience by preventing invalid subdomains from being submitted."

Fixes #72

Screenshot 2023-10-08 at 5 08 46 PM

How should this be tested?

Attempt to create a new project.
Enter a valid project name (between 3 to 17 characters).
Enter a valid subdomain (at least 3 characters, containing only letters and numbers).
Verify that the form submits successfully without any validation errors.
Attempt to create a new project with an invalid subdomain (special characters or spaces).
Verify that an appropriate error message is displayed, preventing the form submission.
Attempt to create a new project with an invalid project name (less than 3 characters or more than 17 characters).
Verify that an appropriate error message is displayed, preventing the form submission.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Thank you for following the naming conventions! 🙏

@github-actions github-actions bot added bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted labels Oct 8, 2023
@piyushgarg-dev piyushgarg-dev merged commit ab6c280 into piyushgarg-dev:main Oct 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Add validation on subdomain while creating Project
2 participants