fix: Add validation on subdomain while creating Project #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 |
github-actions
bot
added
good first issue
saimadib
changed the title
saimadib
changed the title
|
@saimadib Please avoid pushing the package-lock.json file |
|
Hey there, there is a merge conflict, can you take a look? |
|
Closing in Ref #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the issue of validating subdomain while creating project. The subdomain is now having typechecking for spaces, special characters and allows only lower case letters.
Fixes #72
Screenshot
Type of change
How should this be tested?
-Signin to app.localhost:3000/signin
-Go to Dashboard app.localhost:3000/dashboard
-Create a new Project
-Add subdomain as hey there@
-It will give an type error cause there is space and special characters in subdomain "hey there@"