Fix some things with regards to the sector map #4906
Conversation
|
Your second point makes me nervous. What are the jumpable object? As far as I know, we do not consider grav points to be jumpable. Also, it's unclear to me how one selects which star, in a binary system (e.g. Sirius), one will jump to. I know I can set it from "Planetary Info" (C++/OldUI), but how would one set if from sector view? |
You can select a specific body in the list at the objectinfo widget, and it will also be displayed in the route, (if added), and the jump will be made on it:
If you look at the Altair system, this is a single system, and there is only one star in the list: But in the system info screen, you can see that there is a substellar object Altair f, and you can also select it for a jump. The problem is that this is not visible in the sector map, and in this PR I fix it, now all the objects that can be selected for the jump are displayed in the list in the sector map, and are fixed in the route. |
I wonder if that is a bug, that we even make the thingy jumpable? Let's say Jupiter was ignited (like in the plot of the 2001 sequel), making it a brown dwarf, should that be considered a "jumpable" object? |
I don't know much about astronomy, apparently Altair f is not so big that it was a binary system, but big enough to jump on it. By the way, it is 3 times larger than Jupiter, and 14 times heavier. P.S. or maybe add the ability to jump to planets like Jupiter too? |
|
Brown dwarfs should be jumpable, because there are systems that only has brown dwarves. It would make sense that we could jump to them even if they shared the system with a more massive body. I would disagree with jumping to Jupiter or sub-Jupiter sized gas giants though, if you can jump everywhere, what do you need all that Delta-V for? |
|
What if all bodies above a certain mass are jumpable, and as a backup measure the root body of the system is always jumpable? |
|
Oops, seems I've opened pandoras box, I suggest we take further discussions elsewhere. What this PR addresses, is that things work consistently in different UIs, so all good. |
|
I think I caught UB related to the route list, and I'm going to fix it here. |
- clear route strings when enging the game, otherwise, when the game restarts, a segfault occurs - fix that the "remove jump" button continued to remove jumps even when the route became empty - reordered sections in the object information widget, added icons to the names of stars in the multisystem - it turns out that a hyper jump is possible not only to the stars, but also to the "substellar objects", but they do not return in the method GetStars. Since a specific body should be shown in the route planner, implemented an additional method GetJumpable, that gets all the bodies available for jumping (IsJumpable == true), and this is synchronized with what you can click in the systeminfo view - also I had to change the route check, now it’s not the star index that is checked, but just the path (this check is performed for multisystems, so that only the specific body that registered in the route is always selected) - remove method SectorView::SwapSelectedHyperspaceTarget, because it is not used anywhere - clang satisfaction
|
@Web-eWorks do you want to review this? Do you have time the comming days? |
impaktor
changed the title
Gliese852
force-pushed
the
route-fixes
branch
2 times, most recently
from
109e981 to
22e3571
Compare
Gliese852
changed the title
- fix that Auto Route button crashes game when no hyperdrive fitted. Add 3 possible options - successful route building, no drive, no valid route. Also turn the last static function in LuaSectorView.cpp into a lambda, because it turned out that it was not needed in other functions. - fix that when moving the SectorView camera by entering coordinates to the search field, the camera position gets "locked" to the coordinates and you can't move it (now it moves only when the search bar changes)
|
I should be able to review this over the weekend. Thanks @Gliese852 for your work on this! |
clear route strings when enging the game, otherwise, when the game restarts, a segfault occurs
it turns out that a hyper jump is possible not only to the stars, but also to the "substellar objects", but they do not return in the method
GetStars. Since a specific body should be shown in the route planner, implemented an additional methodGetJumpable, that gets all the bodies available for jumping(IsJumpable == true), and this is synchronized with what you can click in the systeminfo viewalso I had to change the route check, now it’s not the star index that is checked, but just the path (this check is performed for multisystems, so that only the specific body that registered in the route is always selected)
fix that the "remove jump" button continued to remove jumps even when the route became empty
reordered sections in the object information widget, added icons to the names of stars in the multisystem
remove method
SectorView::SwapSelectedHyperspaceTarget, because it is not used anywhereadd a module for creating message boxes
fix that Auto Route button crashes game when no hyperdrive fitted. Add 3 possible options - successful route building, no drive, no valid route. Also turn the last static function in
LuaSectorView.cppinto a lambda, because it turned out that it was not needed in other functions. Fixes Sector Map: Auto Route button crashes game when no hyperdrive fitted #4667fix that when moving the SectorView camera by entering coordinates to the search field, the camera position gets "locked" to the coordinates and you can't move it (now it moves only when the search bar changes) Fixes Do not "lock" camera when searching with coordinates in the Sector View #4353
P.S. The system closest to the Sol, in which there is "substellar object", that is jumpable, but not in the list of the stars - Altair.