Fix/remove extra space #141
Conversation
|
This is basically creating churn between space formatting and tab formatting. @Zirak introduced space formatting because they found it easier to read the formatted output. @dublx converted it to tab based formatting for more consistency. I think we need a better solution than alternating between these two every few months. |
|
@jsumners wdyt? should we land this or not? |
I really don't think so. Not until the parties involved that have been interested in this formatting speak up (@Zirak and @dublx). My opinion is we remove this alignment formatting feature completely if no one is able to propose a solution that works as everyone expects. It seems to me that the issue is down to the terminal emulator and font being used and how they present I just don't know how we can satisfy all desires here easily. Reverting the |
|
Aye, I totally agree. |
|
I think we should revert the feature. |
|
@arthurw1 would you like to create a PR that completely reverts the space formatting feature? |
|
@jsumners Yes I can take that on. I will simply make the changes on top of this current branch if that's ok. |
|
That is fine. |
This reverts commit ec09288.
arthurw1
force-pushed
the
fix/remove-extra-space
branch
from
6f2bd89 to
6675125
Compare
|
@mcollina do we think this is patch, minor, or major? I think I could make an argument for any one of them. |
|
I would land this as a minor. If you are parsing this manually you are doing it wrong. |
This PR addresses #140
Update
This PR removes all alignment spaces for log level constants.
The change here is simply to revert #135
The extra spaces highlighted in #140 was caused by using
\tas delimiter.Result:
