Use tab to align output of all levels (pinojs#135)

Use tab to align output of all levels instead of a single space to align only INFO/WARN levels
arthurw1 · Oct 5, 2020 · ec09288 · ec09288
1 parent 820008c
commit ec09288
Show file tree

Hide file tree

Showing 8 changed files with 58 additions and 58 deletions.
diff --git a/lib/constants.js b/lib/constants.js
@@ -17,8 +17,8 @@ module.exports = {
     default: 'USERLVL',
     60: 'FATAL',
     50: 'ERROR',
-    40: 'WARN ',
-    30: 'INFO ',
+    40: 'WARN',
+    30: 'INFO',
     20: 'DEBUG',
     10: 'TRACE'
   },

diff --git a/lib/utils.js b/lib/utils.js
@@ -180,7 +180,7 @@ function prettifyErrorLog ({
  */
 function prettifyLevel ({ log, colorizer = defaultColorizer, levelKey = LEVEL_KEY }) {
   if (levelKey in log === false) return undefined
-  return colorizer(log[levelKey])
+  return colorizer(log[levelKey]) + '\t'
 }
 
 /**

diff --git a/test/basic.test.js b/test/basic.test.js
@@ -49,7 +49,7 @@ test('basic prettifier tests', (t) => {
         const formatted = pretty(chunk.toString())
         t.is(
           formatted,
-          `[${epoch}] INFO  (${pid} on ${hostname}): foo\n`
+          `[${epoch}] INFO\t (${pid} on ${hostname}): foo\n`
         )
         cb()
       }
@@ -65,7 +65,7 @@ test('basic prettifier tests', (t) => {
         const formatted = pretty(chunk.toString())
         t.is(
           formatted,
-          `[${epoch}] \u001B[32mINFO \u001B[39m (${pid} on ${hostname}): \u001B[36mfoo\u001B[39m\n`
+          `[${epoch}] \u001B[32mINFO\u001B[39m\t (${pid} on ${hostname}): \u001B[36mfoo\u001B[39m\n`
         )
         cb()
       }
@@ -81,7 +81,7 @@ test('basic prettifier tests', (t) => {
         const formatted = pretty(chunk.toString())
         t.is(
           formatted,
-          `INFO  [${epoch}] (${pid} on ${hostname}): foo\n`
+          `INFO\t [${epoch}] (${pid} on ${hostname}): foo\n`
         )
         cb()
       }
@@ -97,7 +97,7 @@ test('basic prettifier tests', (t) => {
         const formatted = pretty(chunk.toString())
         t.is(
           formatted,
-          `[${epoch}] INFO  (${pid} on ${hostname}): baz\n`
+          `[${epoch}] INFO\t (${pid} on ${hostname}): baz\n`
         )
         cb()
       }
@@ -113,7 +113,7 @@ test('basic prettifier tests', (t) => {
         const formatted = pretty(chunk.toString())
         t.is(
           formatted,
-          `[${epoch}] WARN  (${pid} on ${hostname}): foo\n`
+          `[${epoch}] WARN\t (${pid} on ${hostname}): foo\n`
         )
         cb()
       }
@@ -129,7 +129,7 @@ test('basic prettifier tests', (t) => {
         const formatted = pretty(chunk.toString())
         t.is(
           formatted,
-          `[2018-03-30 17:35:28.992 +0000] INFO  (${pid} on ${hostname}): foo\n`
+          `[2018-03-30 17:35:28.992 +0000] INFO\t (${pid} on ${hostname}): foo\n`
         )
         cb()
       }
@@ -147,7 +147,7 @@ test('basic prettifier tests', (t) => {
         const offset = dateformat(epoch, 'UTC:' + 'o')
         t.is(
           formatted,
-          `[${utcHour}:35:28 ${offset}] INFO  (${pid} on ${hostname}): foo\n`
+          `[${utcHour}:35:28 ${offset}] INFO\t (${pid} on ${hostname}): foo\n`
         )
         cb()
       }
@@ -166,7 +166,7 @@ test('basic prettifier tests', (t) => {
         const offset = dateformat(epoch, 'o')
         t.is(
           formatted,
-          `[${localDate} ${localHour}:35:28.992 ${offset}] INFO  (${pid} on ${hostname}): foo\n`
+          `[${localDate} ${localHour}:35:28.992 ${offset}] INFO\t (${pid} on ${hostname}): foo\n`
         )
         cb()
       }
@@ -187,7 +187,7 @@ test('basic prettifier tests', (t) => {
         const offset = dateformat(epoch, 'o')
         t.is(
           formatted,
-          `[${localDate} ${localHour}:35:28 ${offset}] INFO  (${pid} on ${hostname}): foo\n`
+          `[${localDate} ${localHour}:35:28 ${offset}] INFO\t (${pid} on ${hostname}): foo\n`
         )
         cb()
       }
@@ -209,7 +209,7 @@ test('basic prettifier tests', (t) => {
     const log = pino({ base: null }, new Writable({
       write (chunk, enc, cb) {
         const formatted = pretty(chunk.toString())
-        t.match(formatted, /\[.*\] INFO : hello world/)
+        t.match(formatted, /\[.*\] INFO\t: hello world/)
         cb()
       }
     }))
@@ -221,7 +221,7 @@ test('basic prettifier tests', (t) => {
     const pretty = prettyFactory()
     const name = 'test'
     const msg = 'hello world'
-    const regex = new RegExp('\\[.*\\] INFO  \\(' + name + ' on ' + hostname + '\\): ' + msg)
+    const regex = new RegExp('\\[.*\\] INFO\t \\(' + name + ' on ' + hostname + '\\): ' + msg)
 
     const opts = {
       base: {
@@ -245,7 +245,7 @@ test('basic prettifier tests', (t) => {
     const pretty = prettyFactory()
     const name = 'test'
     const msg = 'hello world'
-    const regex = new RegExp('\\[.*\\] INFO  \\(' + name + '/' + pid + '\\): ' + msg)
+    const regex = new RegExp('\\[.*\\] INFO\t \\(' + name + '/' + pid + '\\): ' + msg)
 
     const opts = {
       base: {
@@ -268,7 +268,7 @@ test('basic prettifier tests', (t) => {
     t.plan(1)
     const pretty = prettyFactory()
     const msg = 'hello world'
-    const regex = new RegExp('\\[.*\\] INFO  \\(' + process.pid + ' on ' + hostname + '\\): ' + msg)
+    const regex = new RegExp('\\[.*\\] INFO\t \\(' + process.pid + ' on ' + hostname + '\\): ' + msg)
 
     const opts = {
       base: {
@@ -293,7 +293,7 @@ test('basic prettifier tests', (t) => {
     const log = pino({ timestamp: null }, new Writable({
       write (chunk, enc, cb) {
         const formatted = pretty(chunk.toString())
-        t.is(formatted, `INFO  (${pid} on ${hostname}): hello world\n`)
+        t.is(formatted, `INFO\t (${pid} on ${hostname}): hello world\n`)
         cb()
       }
     }))
@@ -344,7 +344,7 @@ test('basic prettifier tests', (t) => {
     const log = pino({ name: 'matteo' }, new Writable({
       write (chunk, enc, cb) {
         const formatted = pretty(chunk.toString())
-        t.is(formatted, `[${epoch}] INFO  (matteo/${pid} on ${hostname}): hello world\n`)
+        t.is(formatted, `[${epoch}] INFO\t (matteo/${pid} on ${hostname}): hello world\n`)
         cb()
       }
     }))
@@ -411,7 +411,7 @@ test('basic prettifier tests', (t) => {
       write (chunk, enc, cb) {
         t.is(
           chunk.toString(),
-          `[${epoch}] INFO  (${pid} on ${hostname}): foo\n`
+          `[${epoch}] INFO\t (${pid} on ${hostname}): foo\n`
         )
         cb()
       }
@@ -431,7 +431,7 @@ test('basic prettifier tests', (t) => {
       write (formatted, enc, cb) {
         t.is(
           formatted,
-          `INFO  [${epoch}] (${pid} on ${hostname}): foo\n`
+          `INFO\t [${epoch}] (${pid} on ${hostname}): foo\n`
         )
         cb()
       }
@@ -451,7 +451,7 @@ test('basic prettifier tests', (t) => {
     const expected = [
       undefined,
       undefined,
-      `[${epoch}] INFO  (${pid} on ${hostname}): foo\n    foo: {\n      "bar": true\n    }\n`
+      `[${epoch}] INFO\t (${pid} on ${hostname}): foo\n    foo: {\n      "bar": true\n    }\n`
     ]
     const log = pino({}, new Writable({
       write (chunk, enc, cb) {
@@ -475,7 +475,7 @@ test('basic prettifier tests', (t) => {
     let formatted = pretty(`{"msg":"nope", "time":${epoch}, "level":30}`)
     t.is(formatted, undefined)
     formatted = pretty(`{"msg":"hello world", "time":${epoch}, "level":30}`)
-    t.is(formatted, `[${epoch}] INFO : hello world\n`)
+    t.is(formatted, `[${epoch}] INFO\t: hello world\n`)
   })
 
   t.test('formats a line with an undefined field', (t) => {
@@ -489,7 +489,7 @@ test('basic prettifier tests', (t) => {
         const formatted = pretty(obj)
         t.is(
           formatted,
-          `[${epoch}] INFO  (${pid} on ${hostname}): foo\n`
+          `[${epoch}] INFO\t (${pid} on ${hostname}): foo\n`
         )
         cb()
       }
@@ -560,7 +560,7 @@ test('basic prettifier tests', (t) => {
       }
     })
     const arst = pretty('{"msg":"hello world", "foo": "bar", "cow": "moo", "level":30}')
-    t.is(arst, 'INFO : hello world\n    foo: bar_baz\n    multiline\n    cow: MOO\n')
+    t.is(arst, 'INFO\t: hello world\n    foo: bar_baz\n    multiline\n    cow: MOO\n')
   })
 
   t.test('does not prettify custom key that does not exists', (t) => {
@@ -572,7 +572,7 @@ test('basic prettifier tests', (t) => {
       }
     })
     const arst = pretty('{"msg":"hello world", "foo": "bar", "level":30}')
-    t.is(arst, 'INFO : hello world\n    foo: bar_baz\n')
+    t.is(arst, 'INFO\t: hello world\n    foo: bar_baz\n')
   })
 
   t.test('prettifies object with some undefined values', (t) => {
@@ -581,7 +581,7 @@ test('basic prettifier tests', (t) => {
       write (chunk, _, cb) {
         t.is(
           chunk + '',
-          `[${epoch}] INFO  (${pid} on ${hostname}):\n    a: {\n      "b": "c"\n    }\n    n: null\n`
+          `[${epoch}] INFO\t (${pid} on ${hostname}):\n    a: {\n      "b": "c"\n    }\n    n: null\n`
         )
         cb()
       }
@@ -604,21 +604,21 @@ test('basic prettifier tests', (t) => {
     t.plan(1)
     const pretty = prettyFactory({ ignore: 'pid,hostname' })
     const arst = pretty(`{"msg":"hello world", "pid":"${pid}", "hostname":"${hostname}", "time":${epoch}, "level":30}`)
-    t.is(arst, `[${epoch}] INFO : hello world\n`)
+    t.is(arst, `[${epoch}] INFO\t: hello world\n`)
   })
 
   t.test('ignores a single key', (t) => {
     t.plan(1)
     const pretty = prettyFactory({ ignore: 'pid' })
     const arst = pretty(`{"msg":"hello world", "pid":"${pid}", "hostname":"${hostname}", "time":${epoch}, "level":30}`)
-    t.is(arst, `[${epoch}] INFO  (on ${hostname}): hello world\n`)
+    t.is(arst, `[${epoch}] INFO\t (on ${hostname}): hello world\n`)
   })
 
   t.test('ignores time', (t) => {
     t.plan(1)
     const pretty = prettyFactory({ ignore: 'time' })
     const arst = pretty(`{"msg":"hello world", "pid":"${pid}", "hostname":"${hostname}", "time":${epoch}, "level":30}`)
-    t.is(arst, `INFO  (${pid} on ${hostname}): hello world\n`)
+    t.is(arst, `INFO\t (${pid} on ${hostname}): hello world\n`)
   })
 
   t.test('ignores time and level', (t) => {
@@ -656,7 +656,7 @@ test('basic prettifier tests', (t) => {
         const formatted = pretty(chunk.toString())
         t.is(
           formatted,
-          `[${epoch}] INFO  (${pid} on ${hostname}) </tmp/script.js>: foo\n`
+          `[${epoch}] INFO\t (${pid} on ${hostname}) </tmp/script.js>: foo\n`
         )
         cb()
       }
@@ -668,7 +668,7 @@ test('basic prettifier tests', (t) => {
     t.plan(1)
     const pretty = prettyFactory({ timestampKey: '@timestamp' })
     const arst = pretty(`{"msg":"hello world", "@timestamp":${epoch}, "level":30}`)
-    t.is(arst, `[${epoch}] INFO : hello world\n`)
+    t.is(arst, `[${epoch}] INFO\t: hello world\n`)
   })
 
   t.test('keeps "v" key in log', (t) => {
@@ -677,7 +677,7 @@ test('basic prettifier tests', (t) => {
     const log = pino({}, new Writable({
       write (chunk, enc, cb) {
         const formatted = pretty(chunk.toString())
-        t.is(formatted, `INFO  (${pid} on ${hostname}):\n    v: 1\n`)
+        t.is(formatted, `INFO\t (${pid} on ${hostname}):\n    v: 1\n`)
         cb()
       }
     }))

diff --git a/test/cli-rc.test.js b/test/cli-rc.test.js
@@ -26,7 +26,7 @@ test('cli', (t) => {
     // Validate that the time has been translated
     child.on('error', t.threw)
     child.stdout.on('data', (data) => {
-      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO  (42 on foo): hello world\n')
+      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO\t (42 on foo): hello world\n')
     })
     child.stdin.write(logLine)
     t.tearDown(() => {
@@ -45,7 +45,7 @@ test('cli', (t) => {
     // Validate that the time has been translated
     child.on('error', t.threw)
     child.stdout.on('data', (data) => {
-      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO  (42 on foo): hello world\n')
+      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO\t (42 on foo): hello world\n')
     })
     child.stdin.write(logLine)
     t.tearDown(() => {
@@ -64,7 +64,7 @@ test('cli', (t) => {
     // Validate that the time has been translated
     child.on('error', t.threw)
     child.stdout.on('data', (data) => {
-      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO  (42 on foo): hello world\n')
+      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO\t (42 on foo): hello world\n')
     })
     child.stdin.write(logLine)
     t.tearDown(() => {
@@ -83,7 +83,7 @@ test('cli', (t) => {
     // Validate that the time has been translated
     child.on('error', t.threw)
     child.stdout.on('data', (data) => {
-      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO  (42 on foo): hello world\n')
+      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO\t (42 on foo): hello world\n')
     })
     child.stdin.write(logLine)
     t.tearDown(() => child.kill())
@@ -99,7 +99,7 @@ test('cli', (t) => {
     // Validate that the time has been translated
     child.on('error', t.threw)
     child.stdout.on('data', (data) => {
-      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO  (42 on foo): hello world\n')
+      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO\t (42 on foo): hello world\n')
     })
     child.stdin.write(logLine)
     t.tearDown(() => child.kill())
@@ -121,7 +121,7 @@ test('cli', (t) => {
     // Validate that the time has been translated and correct message key has been used
     child.on('error', t.threw)
     child.stdout.on('data', (data) => {
-      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO  (42 on foo): hello world\n')
+      t.is(data.toString(), '[2018-03-30 17:35:28.992 +0000] INFO\t (42 on foo): hello world\n')
     })
     child.stdin.write(logLine.replace(/"msg"/, '"new_msg"'))
     t.tearDown(() => {
@@ -145,7 +145,7 @@ test('cli', (t) => {
     // Validate that the time has been translated and correct message key has been used
     child.on('error', t.threw)
     child.stdout.on('data', (data) => {
-      t.is(data.toString(), '[1594416696006] FATAL: There was an error starting the process.\n    QueryError: Error during sql query: syntax error at or near SELECTT\n        at /home/me/projects/example/sql.js\n        at /home/me/projects/example/index.js\nquerySql: SELECTT * FROM "test" WHERE id = $1;\nqueryArgs: 12\n')
+      t.is(data.toString(), '[1594416696006] FATAL\t: There was an error starting the process.\n    QueryError: Error during sql query: syntax error at or near SELECTT\n        at /home/me/projects/example/sql.js\n        at /home/me/projects/example/index.js\nquerySql: SELECTT * FROM "test" WHERE id = $1;\nqueryArgs: 12\n')
     })
     child.stdin.write('{"level":60,"time":1594416696006,"msg":"There was an error starting the process.","type":"Error","stack":"QueryError: Error during sql query: syntax error at or near SELECTT\\n    at /home/me/projects/example/sql.js\\n    at /home/me/projects/example/index.js","querySql":"SELECTT * FROM \\"test\\" WHERE id = $1;","queryArgs":[12]}\n')
     t.tearDown(() => {