add delay clean table lock #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsishandsome
requested review from
zhexuany and
birdstorm
and removed request for
zhexuany
|
/run-all-tests |
birdstorm
reviewed
Jul 5, 2019
marsishandsome
force-pushed
the
feature/delay-clean-table-lock
branch
from
588f407
to
27d5c2a
Compare
|
/run-all-tests |
zhexuany
reviewed
Jul 5, 2019
zhexuany
approved these changes
Jul 5, 2019
|
/run-all-tests |
|
@birdstorm PTAL again |
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #904
The logic of TiSpark to use the table lock is:
The problem is, What if the session was closed by unexpected between step 3 and 4, It will cause some problem.
TiSpark need to delayed release table lock before do commit.