New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate delay-clean-table-lock #904

Closed

marsishandsome opened this issue Jul 4, 2019 · 0 comments · Fixed by #905

Assignees

Collaborator

marsishandsome commented Jul 4, 2019 •

edited

Loading

see pingcap/tidb#11038

The logic of TiSpark to use the table lock is:

lock table
prewrite data.
check whether the locked table session is closed.
if the session doesn't close, do commit.
if the session was closed by unexpected, do a rollback.

The problem is, What if the session was closed by unexpected between step 3 and 4, It will cause some problem.

TiSpark need to delayed release table lock before do commit.

marsishandsome self-assigned this

marsishandsome mentioned this issue

add delay clean table lock #905

Merged

marsishandsome closed this as completed in #905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment