Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #295
Problem Summary:
getCfgCombinations
is wrong: the slice ofappend(o, cfg)
is reused and thus overwrites previous slices, so the test doesn't cover all the cases.cfg.clientConfig.capability = defaultTestClientCapability & ^pnet.ClientPSMultiResults
overwrites other capabilities. It should becfg.clientConfig.capability &= ^pnet.ClientPSMultiResults
to only change the current capability. It also doesn't cover all the cases.What is changed and how it works:
getCfgCombinations
.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.