Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some bugs in testcases in authenticator #295

Closed
djshow832 opened this issue May 31, 2023 · 0 comments · Fixed by #296
Closed

Some bugs in testcases in authenticator #295

djshow832 opened this issue May 31, 2023 · 0 comments · Fixed by #296
Assignees
@djshow832

Comments

@djshow832
Copy link
Collaborator

Bug Report

  • The result of the function getCfgCombinations is wrong: the slice of append(o, cfg) is reused and thus overwrites previous slices, so the test doesn't cover all the cases.
  • The cfgOverriders are wrong. E.g. cfg.clientConfig.capability = defaultTestClientCapability & ^pnet.ClientPSMultiResults overwrites other capabilities. It should be cfg.clientConfig.capability &= ^pnet.ClientPSMultiResults to only change the current capability. It also doesn't cover all the cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djshow832 djshow832

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backend: fix authenticator tests djshow832/TiProxy
1 participant
@djshow832