net: move OnConnClose before Swap #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackendIO conn like ServerAddr() Signed-off-by: whl <wanghongliang@pingcap.com>
better0332
force-pushed
the
fix_OnConnClose
branch
from
4d72deb to
2851059
Compare
xhebox
reviewed
May 12, 2023
| addr = backendIO.RemoteAddr().String() | ||
| connErr = backendIO.Close() | ||
| } | ||
| mgr.processLock.Unlock() | ||
|
|
||
| handErr := mgr.handshakeHandler.OnConnClose(mgr) |
There was a problem hiding this comment.
Maybe we can just invoke OnConnClose before L639?
There was a problem hiding this comment.
I think OnHandshake is only called after the task is completed, and it also has processLock protection. just move before L639?
…conn like ServerAddr() Signed-off-by: whl <wanghongliang@pingcap.com>
…conn like ServerAddr() Signed-off-by: whl <wanghongliang@pingcap.com>
better0332
changed the title
djshow832
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close None
Problem Summary:
move OnConnClose before Swap, because OnConnClose may call backendIO conn like ServerAddr()
What is changed and how it works:
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.