store nil backendIO after OnConnClose, because OnConnClose may call b…

…ackendIO conn like ServerAddr() Signed-off-by: whl <wanghongliang@pingcap.com>
pingcap · May 12, 2023 · 2851059 · 2851059
1 parent d0e6292
commit 2851059
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/proxy/backend/backend_conn_mgr.go b/pkg/proxy/backend/backend_conn_mgr.go
@@ -636,13 +636,13 @@ func (mgr *BackendConnManager) Close() error {
 	var connErr error
 	var addr string
 	mgr.processLock.Lock()
-	if backendIO := mgr.backendIO.Swap(nil); backendIO != nil {
+	if backendIO := mgr.backendIO.Load(); backendIO != nil {
 		addr = backendIO.RemoteAddr().String()
 		connErr = backendIO.Close()
 	}
-	mgr.processLock.Unlock()
-
 	handErr := mgr.handshakeHandler.OnConnClose(mgr)
+	mgr.backendIO.Store(nil)
+	mgr.processLock.Unlock()
 
 	eventReceiver := mgr.getEventReceiver()
 	if eventReceiver != nil {