Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncer(dm): update dep to remove clone for TableInfo #7590

Merged
merged 8 commits into from
Nov 18, 2022
Merged

syncer(dm): update dep to remove clone for TableInfo #7590

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0122af4
syncer(dm): remove clone for TableInfo
lance6716 Nov 12, 2022
3c73529
update dep
lance6716 Nov 14, 2022
e97bf64
Merge branch 'master' of github.com:pingcap/tiflow into remove-clone
lance6716 Nov 14, 2022
26950c7
fix UT
lance6716 Nov 15, 2022
5aaf1dd
change MinGCPercent
lance6716 Nov 15, 2022
ddfa2bd
Merge branch 'master' of github.com:pingcap/tiflow into remove-clone
lance6716 Nov 16, 2022
3b04a2d
Merge branch 'master' into remove-clone
ti-chi-bot Nov 18, 2022
42476bd
Merge branch 'master' into remove-clone
ti-chi-bot Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions dm/pkg/schema/tracker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,7 @@ func (tr *Tracker) GetTableInfo(table *filter.Table) (*model.TableInfo, error) {
if tr.closed.Load() {
return nil, dmterror.ErrSchemaTrackerIsClosed.New("fail to get table info")
}
ti, err := tr.upstreamTracker.TableByName(model.NewCIStr(table.Schema), model.NewCIStr(table.Name))
if err != nil {
return nil, err
}
return ti.Clone(), nil
return tr.upstreamTracker.TableByName(model.NewCIStr(table.Schema), model.NewCIStr(table.Name))
}

// GetCreateTable returns the `CREATE TABLE` statement of the table.
Expand Down
1 change: 1 addition & 0 deletions engine/executor/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ func (s *Server) Run(ctx context.Context) error {
zap.Uint64("memory limit", limit),
zap.Uint64("threshold", threshold))
gctuner.EnableGOGCTuner.Store(true)
gctuner.SetMinGCPercent(20)
gctuner.Tuning(threshold)
}

Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ require (
github.com/pingcap/failpoint v0.0.0-20220423142525-ae43b7f4e5c3
github.com/pingcap/kvproto v0.0.0-20221103025916-e7e21f0e9cd9
github.com/pingcap/log v1.1.1-0.20221110065318-21a4942860b3
github.com/pingcap/tidb v1.1.0-beta.0.20221114050554-9f9d28952991
github.com/pingcap/tidb v1.1.0-beta.0.20221114102155-bdcb85031e07
github.com/pingcap/tidb-tools v6.1.1-0.20220715000306-1d2f00da8c3e+incompatible
github.com/pingcap/tidb/parser v0.0.0-20221114050554-9f9d28952991
github.com/pingcap/tidb/parser v0.0.0-20221114102155-bdcb85031e07
github.com/prometheus/client_golang v1.13.0
github.com/prometheus/client_model v0.2.0
github.com/r3labs/diff v1.1.0
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,15 +1013,15 @@ github.com/pingcap/sysutil v0.0.0-20211208032423-041a72e5860d/go.mod h1:7j18ezaW
github.com/pingcap/sysutil v0.0.0-20220114020952-ea68d2dbf5b4 h1:HYbcxtnkN3s5tqrZ/z3eJS4j3Db8wMphEm1q10lY/TM=
github.com/pingcap/sysutil v0.0.0-20220114020952-ea68d2dbf5b4/go.mod h1:sDCsM39cGiv2vwunZkaFA917vVkqDTGSPbbV7z4Oops=
github.com/pingcap/tidb v1.1.0-beta.0.20220511160835-98c31070d958/go.mod h1:luW4sIZoLHY3bCWuKqyqk2QgMvF+/M7nWOXf/me0+fY=
github.com/pingcap/tidb v1.1.0-beta.0.20221114050554-9f9d28952991 h1:T7GkNRN7nADafi62tfjr0p1fx9/Bq2B/s5vd9SfzFmg=
github.com/pingcap/tidb v1.1.0-beta.0.20221114050554-9f9d28952991/go.mod h1:krwRE9b7/TfAcpt8QCbjZkRpJnoxU/hYfZAkApIxY4I=
github.com/pingcap/tidb v1.1.0-beta.0.20221114102155-bdcb85031e07 h1:sr5oQuyGfx7NkqjjGicwIV1Eg/Xj8GSmDbLV4inBZPI=
github.com/pingcap/tidb v1.1.0-beta.0.20221114102155-bdcb85031e07/go.mod h1:krwRE9b7/TfAcpt8QCbjZkRpJnoxU/hYfZAkApIxY4I=
github.com/pingcap/tidb-dashboard v0.0.0-20220117082709-e8076b5c79ba/go.mod h1:4hk/3owVGWdvI9Kx6yCqqvM1T5PVgwyQNyMQxD3rwfc=
github.com/pingcap/tidb-tools v6.1.1-0.20220715000306-1d2f00da8c3e+incompatible h1:ftmrSd7avCEdTOkWx3O0UkS4yTBrlKQweRF8uqz9+No=
github.com/pingcap/tidb-tools v6.1.1-0.20220715000306-1d2f00da8c3e+incompatible/go.mod h1:XGdcy9+yqlDSEMTpOXnwf3hiTeqrV6MN/u1se9N8yIM=
github.com/pingcap/tidb/parser v0.0.0-20211011031125-9b13dc409c5e/go.mod h1:e1MGCA9Sg3T8jid8PKAEq5eYVuMMCq4n8gJ+Kqp4Plg=
github.com/pingcap/tidb/parser v0.0.0-20220511160835-98c31070d958/go.mod h1:ElJiub4lRy6UZDb+0JHDkGEdr6aOli+ykhyej7VCLoI=
github.com/pingcap/tidb/parser v0.0.0-20221114050554-9f9d28952991 h1:2+vzkm5eXUQBhWdJFJCYlMdZk1mV7zMeIiG7ly1Ve6k=
github.com/pingcap/tidb/parser v0.0.0-20221114050554-9f9d28952991/go.mod h1:wjvp+T3/T9XYt0nKqGX3Kc1AKuyUcfno6LTc6b2A6ew=
github.com/pingcap/tidb/parser v0.0.0-20221114102155-bdcb85031e07 h1:U/f29nLoTYARg2gwQyYzWRGpz6DXUENgI2Mr0eOQAgU=
github.com/pingcap/tidb/parser v0.0.0-20221114102155-bdcb85031e07/go.mod h1:wjvp+T3/T9XYt0nKqGX3Kc1AKuyUcfno6LTc6b2A6ew=
github.com/pingcap/tipb v0.0.0-20220215045658-d12dec7a7609/go.mod h1:A7mrd7WHBl1o63LE2bIBGEJMTNWXqhgmYiOvMLxozfs=
github.com/pingcap/tipb v0.0.0-20221020071514-cd933387bcb5 h1:Yoo8j5xQGxjlsC3yt0ndsiAz0WZXED9rzsKmEN0U0DY=
github.com/pingcap/tipb v0.0.0-20221020071514-cd933387bcb5/go.mod h1:A7mrd7WHBl1o63LE2bIBGEJMTNWXqhgmYiOvMLxozfs=
Expand Down