Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncer(dm): update dep to remove clone for TableInfo #7590

Merged
merged 8 commits into from
Nov 18, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Nov 12, 2022

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: ref #4287

What is changed and how it works?

in the old PR, I'm afraid that TableInfo is changing by SchemaTracker when DMLWorker is accesing, so I clone it before assign it to DMLWorker. But seems DML and DDL job will not be processed simutaneously, this clone is not needed.

Check List

Tests

  • pass original test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2022
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @CharlesCheung96
/run-dm-integration-test

@lance6716
Copy link
Contributor Author

/run-engine-integration-test

@lance6716
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2022
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2022
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2022
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title syncer(dm): remove clone for TableInfo syncer(dm): update dep to remove clone for TableInfo Nov 15, 2022
@lance6716
Copy link
Contributor Author

/cc @okJiang @GMHDBJD @CharlesCheung96

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2022
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find where changes the tableInfo😂, can you give an example? BTW, related problem about version updating is fixed in #7584.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2022
@lance6716
Copy link
Contributor Author

TableInfo is changed in SchemaTracker when handling DDL, pingcap/tidb#39103

An example: TableInfo is read by checkpoint component as a "flushed TableInfo", and when task has error, checkpoint will use flushed TableInfo to rollback some changes. If the TableInfo is mutable, flushed TableInfo may be modified after a DDL
is applied in SchemaTracker, rolling back logic is wrong.

@codecov-commenter
Copy link

Codecov Report

Merging #7590 (ddfa2bd) into master (0438dd4) will decrease coverage by 0.0448%.
The diff coverage is 34.4110%.

Additional details and impacted files
Flag Coverage Δ
cdc 66.7767% <34.4186%> (-0.1401%) ⬇️
engine 63.7810% <0.0000%> (-0.0051%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7590        +/-   ##
================================================
- Coverage   60.0458%   60.0010%   -0.0449%     
================================================
  Files           807        807                
  Lines         92391      92450        +59     
================================================
- Hits          55477      55471         -6     
- Misses        32099      32157        +58     
- Partials       4815       4822         +7     

@lance6716
Copy link
Contributor Author

ptal @CharlesCheung96 @GMHDBJD @okJiang

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ddfa2bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ea47cdd into pingcap:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants