Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chaos(engine): add time shift chaos test #6143

Merged
merged 7 commits into from
Jul 4, 2022

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #5640

What is changed and how it works?

Add chaos shift chaos test

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@amyangfei amyangfei added the area/engine Issues or PRs related to Dataflow Engine. label Jul 1, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • maxshuang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2022
@amyangfei amyangfei marked this pull request as draft July 1, 2022 10:48
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022
@amyangfei amyangfei marked this pull request as ready for review July 3, 2022 02:43
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2022
@amyangfei
Copy link
Contributor Author

@amyangfei amyangfei added the status/ptal Could you please take a look? label Jul 3, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2022
labels:
app: time-shift-dataflow
spec:
mode: one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether different fault scope need to be covered? For example, 80% of pods encounter time failure.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #6143 (778bf36) into master (792faf7) will decrease coverage by 0.8179%.
The diff coverage is 68.5920%.

Flag Coverage Δ
cdc 63.4484% <75.5555%> (-1.7584%) ⬇️
dm 51.8382% <43.1034%> (-0.0856%) ⬇️
engine 62.5900% <74.8792%> (-0.0412%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6143        +/-   ##
================================================
- Coverage   58.6479%   57.8300%   -0.8180%     
================================================
  Files           711        701        -10     
  Lines         83933      83135       -798     
================================================
- Hits          49225      48077      -1148     
- Misses        30258      30694       +436     
+ Partials       4450       4364        -86     

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 4, 2022
@amyangfei
Copy link
Contributor Author

@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2d0667b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 4, 2022
@amyangfei
Copy link
Contributor Author

/merge

1 similar comment
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 0af9d80 into pingcap:master Jul 4, 2022
@amyangfei amyangfei deleted the add-more-chaos-failure branch July 4, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants