Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chaos(engine): enable chaos test in dataflow and add two tests. #5641

Merged
merged 5 commits into from
May 31, 2022

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented May 30, 2022

What problem does this PR solve?

Issue Number: ref #5640

What is changed and how it works?

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@amyangfei amyangfei added the area/engine Issues or PRs related to Dataflow Engine. label May 30, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • liuzix
  • maxshuang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #5641 (c471703) into master (fcea4d5) will increase coverage by 0.5714%.
The diff coverage is 57.7540%.

Flag Coverage Δ
cdc 61.9953% <62.4318%> (+0.8472%) ⬆️
dm 52.0221% <29.5774%> (-0.0206%) ⬇️
engine 58.7121% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5641        +/-   ##
================================================
+ Coverage   56.0768%   56.6482%   +0.5714%     
================================================
  Files           535        675       +140     
  Lines         70143      78885      +8742     
================================================
+ Hits          39334      44687      +5353     
- Misses        27078      30002      +2924     
- Partials       3731       4196       +465     

@amyangfei amyangfei force-pushed the engine-chaos-test branch 2 times, most recently from 4eb8548 to 28973b6 Compare May 30, 2022 07:04
@amyangfei amyangfei added the status/ptal Could you please take a look? label May 30, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 30, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2022
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c471703

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2022
@ti-chi-bot
Copy link
Member

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor Author

/run-verify

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-verify

@ti-chi-bot ti-chi-bot merged commit 06dac5d into pingcap:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants