Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: fix retry getBackoffInMs panic when sleep overflowed (#2280) #2287

Merged
merged 13 commits into from
Jul 18, 2021
Merged

pkg: fix retry getBackoffInMs panic when sleep overflowed (#2280) #2287

merged 13 commits into from
Jul 18, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2280

What problem does this PR solve?

fix sleep*3 overflowed in getBackoffInMs, detected by Test DoCornerCases fails #2273

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

@ben1009 @ti-chi-bot
This is an automated cherry-pick of pingcap#2280
c17477c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2021
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Jul 14, 2021
@ti-chi-bot ti-chi-bot requested a review from lonng July 14, 2021 07:20
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2021
@ben1009
Copy link
Contributor

ben1009 commented Jul 14, 2021

need wait after #2159 merged

@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 14, 2021
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jul 14, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2021
@ti-chi-bot
Copy link
Member Author

@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei amyangfei added this to the v5.1.1 milestone Jul 17, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 8813a7f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 17, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-5.1@0a6e133). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.1      #2287   +/-   ##
================================================
  Coverage               ?   56.0110%           
================================================
  Files                  ?        166           
  Lines                  ?      19855           
  Branches               ?          0           
================================================
  Hits                   ?      11121           
  Misses                 ?       7661           
  Partials               ?       1073

@amyangfei
Copy link
Contributor

/merge

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 9f2c5ca into pingcap:release-5.1 Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben1009 ben1009 ben1009 approved these changes

@lonng lonng Awaiting requested review from lonng

@amyangfei amyangfei Awaiting requested review from amyangfei

@liuzix liuzix Awaiting requested review from liuzix

Assignees

@ben1009 ben1009

Labels
cherry-pick-approved Cherry pick PR approved by release team. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @ben1009 @amyangfei @codecov-commenter @lonng