pkg: fix retry getBackoffInMs panic when sleep overflowed (#2280) (#2287

)
pingcap · Jul 18, 2021 · 9f2c5ca · 9f2c5ca
1 parent 0a6e133
commit 9f2c5ca
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pkg/retry/retry_with_opt.go b/pkg/retry/retry_with_opt.go
@@ -88,7 +88,10 @@ func getBackoffInMs(backoffBaseInMs, backoffCapInMs, try float64) time.Duration
 	if temp <= 0 {
 		temp = 1
 	}
-	sleep := temp + rand.Int63n(temp)
-	backOff := math.Min(backoffCapInMs, float64(rand.Int63n(sleep*3))+backoffBaseInMs)
+	sleep := (temp + rand.Int63n(temp)) * 3
+	if sleep <= 0 {
+		sleep = math.MaxInt64
+	}
+	backOff := math.Min(backoffCapInMs, float64(rand.Int63n(sleep))+backoffBaseInMs)
 	return time.Duration(backOff) * time.Millisecond
 }