-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: add a new retry to support the error isRetryable or not (#1848) #2157
pkg: add a new retry to support the error isRetryable or not (#1848) #2157
Conversation
@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c4a447c
|
/merge |
/merge |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2157 +/- ##
===================================================
+ Coverage 53.7661% 53.8585% +0.0923%
===================================================
Files 153 165 +12
Lines 15958 17429 +1471
===================================================
+ Hits 8580 9387 +807
- Misses 6475 7053 +578
- Partials 903 989 +86 |
/merge |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #1848
What problem does this PR solve?
ctx.Error()
when got canceled instead of just return err, for more detail check Give reason for Stop cenkalti/backoff#97WithInfiniteTries, WithMaxTries
OptionWhat is changed and how it works?
add a new implementation of retry to support config error retry or not
Check List
Tests
Code changes
Related changes
Release note