-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: add a new retry to support the error isRetryable or not #1848
Conversation
Can we make use of |
i also want reuse |
What's your next step in solving #1724? |
will make the change in another pr, since have 10+ usage exclude tests, do not want involve too many changes in one place.
|
/run-all-tests |
/run-integration-tests |
/run-kafka-tests |
2 similar comments
/run-kafka-tests |
/run-kafka-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6493364
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
=================================================
+ Coverage 37.8006% 52.5803% +14.7797%
=================================================
Files 110 171 +61
Lines 11394 18583 +7189
=================================================
+ Hits 4307 9771 +5464
- Misses 6662 7762 +1100
- Partials 425 1050 +625 |
In response to a cherrypick label: new pull request created: #2157. |
In response to a cherrypick label: new pull request created: #2158. |
In response to a cherrypick label: new pull request created: #2159. |
What problem does this PR solve?
ctx.Error()
when got canceled instead of just return err, for more detail check Give reason for Stop cenkalti/backoff#97WithInfiniteTries, WithMaxTries
OptionWhat is changed and how it works?
add a new implementation of retry to support config error retry or not
Check List
Tests
Code changes
Related changes
Release note