Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update tidb #2109

Merged
merged 5 commits into from
Jun 22, 2021
Merged

*: update tidb #2109

merged 5 commits into from
Jun 22, 2021

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Update TiDB, use tikv/client-go/v2 instead of tidb/store/tikv.

relate to: pingcap/tidb#25359

What is changed and how it works?

go get -u github.com/pingcap/tidb@master
go get -u github.com/tikv/client-go/v2@v2.0.0

Check List

Tests

  • Unit test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 20, 2021
@disksing
fix build
76d562c 
Signed-off-by: disksing <i@disksing.com>
@overvenus
Copy link
Member

Does it need to be cherry-picked to release branches?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@disksing
Copy link
Contributor Author

Does it need to be cherry-picked to release branches?

only master branch.

@disksing
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leoppro
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2021
@zier-one
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 76d562c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@purelind
Copy link
Collaborator

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit dc6de98 into pingcap:master Jun 22, 2021
@disksing disksing deleted the update-tidb-2 branch June 22, 2021 02:16
@amyangfei amyangfei mentioned this pull request Jun 29, 2021
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2021
Merged
@amyangfei amyangfei mentioned this pull request Jul 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@disksing @overvenus @ti-chi-bot @zier-one @purelind @amyangfei