Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use tikv/client-go/v2 #25359

Merged
merged 7 commits into from
Jun 11, 2021
Merged

*: use tikv/client-go/v2 #25359

merged 7 commits into from
Jun 11, 2021

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Jun 11, 2021

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

We want to use client-go/v2 and remove store/tikv.

Part of #22513

What is changed and how it works?

What's Changed:

  • Use tikv/client-go/v2 to replace github.com/pingcap/tidb/store/tikv.
  • store/tikv is untouched as there are other repos use it.
  • Temporary disable TestBackupAndRestore test due to tidb and br dendency problem. We will enable it again as soon as BR switches to use client-go/v2.

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the sig/transaction SIG:Transaction label Jun 11, 2021
@disksing disksing requested review from a team as code owners June 11, 2021 04:22
@disksing disksing requested review from lzmhhh123 and removed request for a team June 11, 2021 04:22
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 11, 2021
@disksing
Copy link
Contributor Author

/run-all-tests

@disksing
Copy link
Contributor Author

/run-all-tests

Signed-off-by: disksing <i@disksing.com>
@disksing
Copy link
Contributor Author

/run-all-tests

@lzmhhh123 lzmhhh123 removed their request for review June 11, 2021 07:21
@disksing disksing removed the request for review from a team June 11, 2021 07:31
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • andylokandy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 11, 2021
@AndreMouche
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 30998c6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@ti-chi-bot ti-chi-bot merged commit cc5e161 into pingcap:master Jun 11, 2021
@disksing disksing deleted the client-v2 branch July 14, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config sig/execution SIG execution sig/migrate sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants