Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: update TiKV metrics #1604 #1607

Merged
merged 4 commits into from
Apr 2, 2021
Merged

metrics: update TiKV metrics #1604 #1607

merged 4 commits into from
Apr 2, 2021

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Apr 2, 2021 •
edited
Loading

What problem does this PR solve?

cherry-pick #1604 into release-5.0

What is changed and how it works?

Update TiKV metrics

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@overvenus @amyangfei
metrics: update TiKV metrics
86f57cb 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus @amyangfei
fix scan tasks metrics
2e0fa16 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus @amyangfei
move ongoing to yaxis
18c2965 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus @amyangfei
Apply suggestions from code review
dad201c
@amyangfei amyangfei added status/ptal Could you please take a look? release-blocker This issue blocks a release. Please solve it ASAP. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Apr 2, 2021
@amyangfei amyangfei added this to the v5.0.0 milestone Apr 2, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 2, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests

zhouqiang-cl
zhouqiang-cl approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: /lgtm is only allowed for the reviewers in list.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2021
@amyangfei amyangfei merged commit 39c1bd9 into pingcap:release-5.0 Apr 2, 2021
@amyangfei amyangfei deleted the cherry-pick-1604 branch April 2, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

@zier-one zier-one Awaiting requested review from zier-one

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
release-blocker This issue blocks a release. Please solve it ASAP. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@amyangfei @ti-chi-bot @overvenus @zhouqiang-cl