Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: update TiKV metrics #1604

Merged
merged 5 commits into from
Apr 3, 2021
Merged

metrics: update TiKV metrics #1604

merged 5 commits into from
Apr 3, 2021

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Update TiKV metrics

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 2, 2021
metrics/grafana/ticdc.json Outdated Show resolved Hide resolved
metrics/grafana/ticdc.json Outdated Show resolved Hide resolved
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. release-blocker This issue blocks a release. Please solve it ASAP. labels Apr 2, 2021
@amyangfei amyangfei added this to the v5.0.0 milestone Apr 2, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 2, 2021
@overvenus overvenus added status/ptal Could you please take a look? size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/WIP size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 2, 2021
@zier-one
Copy link
Contributor

zier-one commented Apr 2, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2021
@liuzix
Copy link
Contributor

liuzix commented Apr 2, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leoppro
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2021
@zier-one
Copy link
Contributor

zier-one commented Apr 2, 2021

/merge

1 similar comment
@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7e0f335

1 similar comment
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7e0f335

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 2, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
metrics/grafana/ticdc.json Outdated Show resolved Hide resolved
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2eea7ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2021
@amyangfei amyangfei removed the needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. label Apr 2, 2021
amyangfei added a commit that referenced this pull request Apr 2, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
@amyangfei
Copy link
Contributor

/merge

@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-io
Copy link

Codecov Report

Merging #1604 (1b2da55) into master (3e215b0) will increase coverage by 0.0312%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #1604        +/-   ##
================================================
+ Coverage   52.9543%   52.9855%   +0.0312%     
================================================
  Files           152        152                
  Lines         16027      16027                
================================================
+ Hits           8487       8492         +5     
+ Misses         6643       6637         -6     
- Partials        897        898         +1     

@ti-chi-bot ti-chi-bot merged commit 6c41167 into master Apr 3, 2021
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Apr 3, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. release-blocker This issue blocks a release. Please solve it ASAP. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants