Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: fix cleanup stale tasks before capture info is constructed (#1269) #1280

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 6, 2021

cherry-pick #1269 to release-4.0


What problem does this PR solve?

Fix #1268, since #1184 has been merged into release-4.0 before 4.0.10 is released, this PR needs to be shipped in 4.0.10 too.

No release since this is a bug fix in non-release version

What is changed and how it works?

Add a flag to record whether capture information is initialized in owner.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@sre-bot
Copy link

sre-bot commented Jan 6, 2021

@amyangfei
Copy link
Contributor

/run-check-release-note

@amyangfei
Copy link
Contributor

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #1280 (257ad35) into release-4.0 (11a746b) will decrease coverage by 0.0287%.
The diff coverage is 100.0000%.

@@                 Coverage Diff                 @@
##           release-4.0      #1280        +/-   ##
===================================================
- Coverage      45.9165%   45.8878%   -0.0288%     
===================================================
  Files              112        112                
  Lines            11767      11770         +3     
===================================================
- Hits              5403       5401         -2     
- Misses            5753       5760         +7     
+ Partials           611        609         -2     

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2021
@liuzix
Copy link
Contributor

liuzix commented Jan 6, 2021

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 6, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jan 6, 2021
@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit c1c91a1 into pingcap:release-4.0 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants