owner: fix cleanup stale tasks before capture info is constructed #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
type/bugfix
|
/run-all-tests |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #1269 +/- ##
================================================
+ Coverage 46.1910% 46.2495% +0.0584%
================================================
Files 129 129
Lines 13022 13025 +3
================================================
+ Hits 6015 6024 +9
+ Misses 6342 6338 -4
+ Partials 665 663 -2 |
|
LGTM |
zier-one
approved these changes
Jan 6, 2021
ti-srebot
approved these changes
Jan 6, 2021
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Jan 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Jan 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
added a commit
that referenced
this pull request
Jan 6, 2021
) (#1280) Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
amyangfei
pushed a commit
that referenced
this pull request
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #1268, since #1184 has been merged into
release-4.0before4.0.10is released, this PR needs to be shipped in4.0.10too.No release since this is a bug fix in non-release version
What is changed and how it works?
Add a flag to record whether capture information is initialized in owner.
Check List
Tests
Release note