Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ticdc): add OWNERS file in cdc api folder #10820

Merged
merged 3 commits into from
Mar 21, 2024
Merged

chore(ticdc): add OWNERS file in cdc api folder #10820

merged 3 commits into from
Mar 21, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Mar 19, 2024 •
edited
Loading

Signed-off-by: wuhuizuo wuhuizuo@126.com

What problem does this PR solve?

Issue Number: close #10819

What is changed and how it works?

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@wuhuizuo
chore(ticdc): add OWNERS file in cdc api folder
2212b16 
ref: 10819
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2024
@wuhuizuo
Copy link
Contributor Author

/run-check-issue-triage-complete

@wuhuizuo
Copy link
Contributor Author

/cc @flowbehappy @okJiang
PTAL

sdojjy
sdojjy reviewed Mar 20, 2024
View reviewed changes
OWNERS_ALIASES Outdated Show resolved Hide resolved
@wuhuizuo @sdojjy
Update OWNERS_ALIASES
0197341 
Co-authored-by: Jianyuan Jiang <sdojjy@qq.com>
@wuhuizuo
Copy link
Contributor Author

/cc @flowbehappy @sdojjy
/uncc @okJiang

@ti-chi-bot ti-chi-bot bot requested review from sdojjy and removed request for okJiang March 20, 2024 02:20
@wuhuizuo
Copy link
Contributor Author

/cc @flowbehappy @okJiang PTAL

sorry for requested wrongly.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 20, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor Author

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/hold

wait for flowbehappy be a repo approver.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 20, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-20 02:29:00.614670799 +0000 UTC m=+1430167.636917188: ☑️ agreed by sdojjy.
  • 2024-03-20 02:29:29.910777361 +0000 UTC m=+1430196.933023749: ☑️ agreed by CharlesCheung96.

@wuhuizuo
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@wuhuizuo
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
flowbehappy
flowbehappy reviewed Mar 21, 2024
View reviewed changes
OWNERS_ALIASES Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot requested a review from hongyunyan March 21, 2024 07:03
hongyunyan
hongyunyan approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@hongyunyan hongyunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, flowbehappy, hongyunyan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,hongyunyan,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wuhuizuo @flowbehappy
Update OWNERS_ALIASES
148984d 
Co-authored-by: Flowyi <flowbehappy@gmail.com>
@wuhuizuo
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit d186087 into pingcap:master Mar 21, 2024
10 checks passed
@wuhuizuo wuhuizuo deleted the wuhuizuo/issue10819 branch March 22, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@sdojjy sdojjy sdojjy approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup OWNERS on cdc/api/v2 folder for CDC API change approval
5 participants
@wuhuizuo @sdojjy @flowbehappy @hongyunyan @CharlesCheung96