Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup OWNERS on cdc/api/v2 folder for CDC API change approval #10819

Closed
4 tasks done
wuhuizuo opened this issue Mar 19, 2024 · 4 comments · Fixed by #10820
Closed
4 tasks done

Setup OWNERS on cdc/api/v2 folder for CDC API change approval #10819

wuhuizuo opened this issue Mar 19, 2024 · 4 comments · Fixed by #10820
Assignees
@wuhuizuo
Labels
question Further information is requested. type/question The issue belongs to a question.

Comments

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Mar 19, 2024 •
edited
Loading

Before asking a question, make sure you have

What is your question?

Like pingcap/tidb#45183

Scope: cdc/api/v2 go source files
Approvers: @flowbehappy @sdojjy @hongyunyan
@wuhuizuo wuhuizuo added the question Further information is requested. label Mar 19, 2024
@wuhuizuo
Copy link
Contributor Author

/assign

@wuhuizuo wuhuizuo mentioned this issue Mar 19, 2024
Merged
@wuhuizuo
Copy link
Contributor Author

/type question

@ti-chi-bot ti-chi-bot bot added the type/question The issue belongs to a question. label Mar 19, 2024
@okJiang
Copy link
Member

okJiang commented Mar 19, 2024

Why is the approver of this folder me? I have never contributed to this folder.

@wuhuizuo
Copy link
Contributor Author

Why is the approver of this folder me? I have never contributed to this folder.

@okJiang
sorry for assign wrong Github ID, it's updated.

ti-chi-bot bot pushed a commit that referenced this issue Mar 21, 2024
@wuhuizuo
chore(ticdc): add OWNERS file in cdc api folder (#10820)
d186087 
close #10819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wuhuizuo wuhuizuo

Labels
question Further information is requested. type/question The issue belongs to a question.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ticdc): add OWNERS file in cdc api folder wuhuizuo/tiflow
2 participants
@wuhuizuo @okJiang