Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine interpreter unit test #6689

Merged
merged 9 commits into from
Jan 30, 2023
Merged

refine interpreter unit test #6689

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3195464
update
SeaRise Jan 29, 2023
21f007f
update
SeaRise Jan 29, 2023
55ad67c
Update dbms/src/TestUtils/InterpreterTestUtils.h
SeaRise Jan 30, 2023
563f3e2
Update dbms/src/TestUtils/InterpreterTestUtils.cpp
SeaRise Jan 30, 2023
4a9969a
address comments
SeaRise Jan 30, 2023
b599afe
add comments
SeaRise Jan 30, 2023
8a12f40
Merge branch 'master' into add_ut_record
SeaRise Jan 30, 2023
3cb4e97
fix comment
SeaRise Jan 30, 2023
bd3b1fc
Merge branch 'master' into add_ut_record
ti-chi-bot Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/licenserc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ header:
- '**/NOTICE'
- 'dbms/src/IO/tests/limit_read_buffer.reference'
- 'dbms/src/IO/tests/DevicePixelRatio'
- 'dbms/src/Flash/tests/gtest_*.out'
- 'Cargo.lock'
- 'Cargo.toml'
- 'rust-toolchain'
Expand Down
2 changes: 1 addition & 1 deletion dbms/src/DataStreams/LimitTransformAction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace DB
namespace
{
// Removes all rows outside of specified range of Block.
void cut(Block & block, size_t rows, size_t limit, size_t pos)
void cut(Block & block, size_t rows [[maybe_unused]], size_t limit, size_t pos)
{
assert(rows + limit > pos);
size_t pop_back_cnt = pos - limit;
Expand Down
Loading