Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine interpreter unit test #6689

Merged
merged 9 commits into from
Jan 30, 2023
Merged

refine interpreter unit test #6689

merged 9 commits into from
Jan 30, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jan 29, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6676

Problem Summary:

What is changed and how it works?

  • move the expect result to separate files
  • Provides a way to update expect results in bulk.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 29, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jan 29, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 29, 2023

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 29, 2023

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 29, 2023

/cc @ywqzzy @windtalker

ywqzzy
ywqzzy reviewed Jan 30, 2023
View reviewed changes
dbms/src/Flash/tests/gtest_interpreter.out Outdated Show resolved Hide resolved
dbms/src/TestUtils/InterpreterTestUtils.cpp Show resolved Hide resolved
dbms/src/TestUtils/InterpreterTestUtils.h Outdated Show resolved Hide resolved
dbms/src/TestUtils/InterpreterTestUtils.cpp Show resolved Hide resolved
SeaRise and others added 3 commits January 30, 2023 11:28
@SeaRise @ywqzzy
Update dbms/src/TestUtils/InterpreterTestUtils.h
55ad67c 
Co-authored-by: yanweiqi <592838129@qq.com>
@SeaRise @ywqzzy
Update dbms/src/TestUtils/InterpreterTestUtils.cpp
563f3e2 
Co-authored-by: yanweiqi <592838129@qq.com>
@SeaRise
address comments
4a9969a
@SeaRise SeaRise requested a review from ywqzzy January 30, 2023 03:42
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 30, 2023
windtalker
windtalker approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dbms/src/Flash/tests/gtest_pipeline_interpreter.cpp

enablePlanner(true);
enablePipeline(true);

// setRecord();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comments here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, added

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 30, 2023
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 30, 2023

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8a12f40

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 30, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 30, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 30, 2023

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3cb4e97

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 30, 2023
@ywqzzy
Copy link
Contributor

ywqzzy commented Jan 30, 2023

/run-integration-tests

@ti-chi-bot
Copy link
Member

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 30, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 30, 2023

/run-unit-test

2 similar comments
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 30, 2023

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 30, 2023

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 30, 2023

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 30, 2023

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit f68e8ff into pingcap:master Jan 30, 2023
@SeaRise SeaRise deleted the add_ut_record branch January 30, 2023 06:58
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
@SeaRise @ywqzzy
refine interpreter unit test (pingcap#6689)
6f63b7e 
close pingcap#6676

Signed-off-by: ywqzzy <592838129@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A more friendly way to update the unit test cases in gtest_interpreter.cpp
4 participants
@SeaRise @ti-chi-bot @ywqzzy @windtalker