Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more metrics for dt (#540) #558

Merged
merged 8 commits into from
Mar 25, 2020
Merged

Add more metrics for dt (#540) #558

merged 8 commits into from
Mar 25, 2020

Conversation

sre-bot
Copy link
Collaborator

@sre-bot sre-bot commented Mar 25, 2020

cherry-pick #540 to release-3.1

  • Added tiflash_write_amplification to prometheus metrics. [FLASH-989]
  • Rename dm_* settings to dt_*. [FLASH-1016]

@sre-bot sre-bot mentioned this pull request Mar 25, 2020
Merged
@sre-bot sre-bot added the CHERRY-PICK cherry pick label Mar 25, 2020
JaySon-Huang
JaySon-Huang approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaySon-Huang JaySon-Huang added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2020
@sre-bot
Copy link
Collaborator Author

sre-bot commented Mar 25, 2020

/run-all-tests

@sre-bot
Copy link
Collaborator Author

sre-bot commented Mar 25, 2020

@sre-bot merge failed.

@JaySon-Huang JaySon-Huang reopened this Mar 25, 2020
@JaySon-Huang
Copy link
Contributor

/merge

@JaySon-Huang JaySon-Huang mentioned this pull request Mar 25, 2020
Closed
@sre-bot
Copy link
Collaborator Author

sre-bot commented Mar 25, 2020

/run-all-tests

@sre-bot
Copy link
Collaborator Author

sre-bot commented Mar 25, 2020

@sre-bot merge failed.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang
Copy link
Contributor

/merge

@sre-bot
Copy link
Collaborator Author

sre-bot commented Mar 25, 2020

Your auto merge job has been accepted, waiting for 553, 543

@JaySon-Huang JaySon-Huang removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2020
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang JaySon-Huang merged commit 5b70ee9 into pingcap:release-3.1 Mar 25, 2020
@JaySon-Huang JaySon-Huang deleted the release-3.1-e8ce4d837b01 branch March 25, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@guliangliangatpingcap guliangliangatpingcap Awaiting requested review from guliangliangatpingcap

@marsishandsome marsishandsome Awaiting requested review from marsishandsome

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

Assignees
No one assigned
Labels
CHERRY-PICK cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sre-bot @JaySon-Huang @flowbehappy