Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more metrics for dt #540

Merged
merged 9 commits into from
Mar 25, 2020
Merged

Add more metrics for dt #540

merged 9 commits into from
Mar 25, 2020

Conversation

flowbehappy
Copy link
Contributor

@flowbehappy flowbehappy commented Mar 21, 2020 •
edited
Loading

  • Added tiflash_write_amplification to prometheus metrics. [FLASH-989]
  • Rename dm_* settings to dt_*. [FLASH-1016]

@JaySon-Huang JaySon-Huang added the needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 label Mar 21, 2020
JaySon-Huang
JaySon-Huang reviewed Mar 21, 2020
View reviewed changes
.clang-format Outdated Show resolved Hide resolved
@flowbehappy
Copy link
Contributor Author

@JaySon-Huang @zanmato1984 PTAL

zanmato1984
zanmato1984 approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics part LGTM.

JaySon-Huang
JaySon-Huang approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flowbehappy
Copy link
Contributor Author

/run-integration-tests

marsishandsome
marsishandsome approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flowbehappy
Copy link
Contributor Author

/run-integration-tests

@flowbehappy flowbehappy added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2020
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 23, 2020

Your auto merge job has been accepted, waiting for 544, 547, 542

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 23, 2020

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 23, 2020

@flowbehappy merge failed.

@JaySon-Huang
Copy link
Contributor

/merge

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2020

Your auto merge job has been accepted, waiting for 544

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2020

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2020

@flowbehappy merge failed.

@flowbehappy
Copy link
Contributor Author

/run-integration-tests

@JaySon-Huang
Copy link
Contributor

/merge

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2020

Your auto merge job has been accepted, waiting for 548

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2020

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2020

@flowbehappy merge failed.

@flowbehappy
Copy link
Contributor Author

/run-all-tests

@flowbehappy flowbehappy merged commit e8ce4d8 into pingcap:master Mar 25, 2020
@sre-bot sre-bot mentioned this pull request Mar 25, 2020
Merged
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 25, 2020

cherry pick to release-3.1 in PR #558

@flowbehappy flowbehappy mentioned this pull request Mar 25, 2020
Closed
JaySon-Huang pushed a commit that referenced this pull request Mar 25, 2020
@sre-bot
Add more metrics for dt (#540) (#558)
5b70ee9 
* WIP: add metrics, and update dm_ settings to dt*

* Do record in flush

* Check index
@marsishandsome marsishandsome mentioned this pull request Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@marsishandsome marsishandsome marsishandsome approved these changes

@guliangliangatpingcap guliangliangatpingcap Awaiting requested review from guliangliangatpingcap

Assignees
No one assigned
Labels
needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flowbehappy @sre-bot @JaySon-Huang @zanmato1984 @marsishandsome