-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] PageStorage: Fix the lifetime of PageEntries in PageDirectory with RefPage
mechanism
#4061
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@@ -0,0 +1 @@ | |||
leak:fiu_enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is added for running asan detection like #4054
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
Find that we need to change the logic in |
RefPage
mechanism RefPage
mechanism
f878158
to
a742a77
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
a19d04d
to
b262256
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
772f19e
to
e2cb6fe
Compare
do it by another design #4174 |
What problem does this PR solve?
Issue Number: a part of #3594
Problem Summary: Fix the lifetime of PageEntries in PageDirectory with RefPage mechanism, the ut:
https://github.com/pingcap/tics/blob/c9960d42f2f701010ff591c2421b4a2b941b03b8/dbms/src/Storages/Page/V3/tests/gtest_page_directory.cpp#L1014-L1047
What is changed and how it works?
PageDirectory
Check List
Tests
Side effects
Documentation
Release note