[WIP] PageStorage: introduce ExternalMap to manage DTFile lifetime #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/work-in-progress
JaySon-Huang
force-pushed
the
fix_ref_id
branch
from
002c7f0
to
d291bc6
Compare
|
/run-unit-test |
JaySon-Huang
force-pushed
the
fix_ref_id
branch
2 times, most recently
from
85c502a
to
0d1ec4b
Compare
|
TODO:
|
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
12 tasks
JaySon-Huang
force-pushed
the
fix_ref_id
branch
from
552da1a
to
332b70e
Compare
jiaqizho
reviewed
Feb 15, 2022
| : iter->second->getEntry(last_sequence + 1)); | ||
| entry) | ||
| { | ||
| // copy the entry to be ref |
There was a problem hiding this comment.
Seem like there still have some GC problem?
If ori_page_id has been removed by gc. then the entry used ref_pageid can't find data?
There was a problem hiding this comment.
Yes, this is an unsolved problem that after implementing the "REF", when should we remove the entry from the BlobStore(spacemap)
There was a problem hiding this comment.
Fixed in #4061
JaySon-Huang
force-pushed
the
fix_ref_id
branch
from
b6692b8
to
a2f7724
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
force-pushed
the
fix_ref_id
branch
from
104a150
to
fb55812
Compare
jiaqizho
approved these changes
Feb 15, 2022
| bool ExternalMap::createExternal(PageId page_id, UInt64 sequence) | ||
| { | ||
| auto [iter, new_inserted] = external_table_directory.insert(std::make_pair(page_id, ExternalPageHolder(page_id, sequence))); | ||
| if (unlikely(!new_inserted)) |
There was a problem hiding this comment.
should we roll back it here?
There was a problem hiding this comment.
Nothing needs to be roll back here.
If new_inserted == false, then iter is an iterator that points to the existing item. Nothing gets inserted or changed so nothing needs to be roll back.
> cat a.cpp
#include <map>
#include <iostream>
using namespace std;
struct A
{
int a, b;
A(int a_, int b_): a(a_), b(b_) {}
};
int main()
{
map<int, A> m;
{
auto [iter, new_inserted] = m.insert(std::make_pair(1, A{1, 2}));
cout << "new: " << new_inserted << ". " << iter->first << ":" << iter->second.a << "," << iter->second.b << endl;
}
{
auto [iter, new_inserted] = m.insert(std::make_pair(1, A{3, 4}));
cout << "new: " << new_inserted << ". " << iter->first << ":" << iter->second.a << "," << iter->second.b << endl;
}
return 0;
}
> g++ a.cpp -std=c++17 && ./a.out
new: 1. 1:1,2
new: 0. 1:1,2
| // Try to apply ref on external pages | ||
| if (!external_directory.tryCreateRef(record.page_id, record.ori_page_id, record.version.sequence)) | ||
| { | ||
| // LOG_FMT_WARNING(log, "Trying to add ref from {} to non-exist {} with seq={}", record.page_id, record.ori_page_id, record.version.sequence); |
There was a problem hiding this comment.
should not return false? or should we throw a exception here, cause it looks like a logic error.
| { | ||
| table_directory.erase(iter); | ||
| // put after ref, must be sth wrong!!! | ||
| // LOG_FMT_WARNING(log, "Trying to add ref from {} to non-exist {} with seq={}", record.page_id, record.ori_page_id, record.version.sequence); |
There was a problem hiding this comment.
I think we should keep this log.
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
do it by another design #4174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4017
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note