Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand streams after agg (#2530) #2537

Merged
merged 3 commits into from
Jan 28, 2022

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Aug 2, 2021

cherry-pick #2530 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2537

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2537:release-5.1-a3a663351625

What problem does this PR solve?

Issue Number: close #2453

Problem Summary: expand streams after aggregation

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    the second agg is parallel, but before this PR, it is non-parallel agg.
["executeQuery: Query pipeline:\nExpression\n Expression\n  ParallelAggregating\n   Expression × 24\n    Expression\n     Expression\n      Expression\n       Expression\n        Expression\n         SimpleInputStream\n          SharedQuery\n           Expression\n            Expression\n             ParallelAggregating\n              Expression × 24\n               Squashing\n                TiRemoteBlockInputStream(ExchangeReceiver)\n"] [thread_id=485]

Side effects

Release note

  • expand streams after aggregation

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2021
@ti-srebot ti-srebot added this to the v5.1.1 milestone Aug 2, 2021
@JaySon-Huang JaySon-Huang modified the milestones: v5.1.1, v5.1.2 Aug 3, 2021
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@fzhedu
Copy link
Contributor

fzhedu commented Aug 10, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2021
@JaySon-Huang JaySon-Huang modified the milestones: v5.1.2, v5.1.3 Oct 11, 2021
@JaySon-Huang JaySon-Huang modified the milestones: v5.1.3, v5.1.4 Dec 28, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 24, 2022
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4fcab35

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 28, 2022
@ti-chi-bot ti-chi-bot merged commit 18e3df0 into pingcap:release-5.1 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick cherry-pick-approved Cherry pick PR approved by release team. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants