Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand streams after agg #2530

Merged
merged 3 commits into from
Jul 30, 2021
Merged

expand streams after agg #2530

merged 3 commits into from
Jul 30, 2021

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Jul 30, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #2453

Problem Summary: expand streams after aggregation

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    the second agg is parallel, but before this PR, it is non-parallel agg.
["executeQuery: Query pipeline:\nExpression\n Expression\n  ParallelAggregating\n   Expression × 24\n    Expression\n     Expression\n      Expression\n       Expression\n        Expression\n         SimpleInputStream\n          SharedQuery\n           Expression\n            Expression\n             ParallelAggregating\n              Expression × 24\n               Squashing\n                TiRemoteBlockInputStream(ExchangeReceiver)\n"] [thread_id=485]

Side effects

Release note

  • expand streams after aggregation

windtalker
windtalker approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Jul 30, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Jul 30, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 30, 2021
@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2313

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit a3a6633 into pingcap:master Jul 30, 2021
@fzhedu fzhedu added needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 labels Aug 2, 2021
@ti-srebot ti-srebot mentioned this pull request Aug 2, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.1 in PR #2537

@ti-srebot ti-srebot mentioned this pull request Aug 2, 2021
Closed
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #2538

This was referenced Aug 4, 2021
Merged
Merged
fzhedu added a commit that referenced this pull request Aug 4, 2021
@fzhedu
expand streams after agg (#2530) (#2558)
00616ef
JaySon-Huang pushed a commit that referenced this pull request Aug 4, 2021
@fzhedu
expand streams after agg (#2530) (#2559)
fd4bcb2
@zanmato1984
Copy link
Contributor

Closes #2444

ti-chi-bot pushed a commit that referenced this pull request Jan 28, 2022
@ti-srebot
expand streams after agg (#2530) (#2537)
18e3df0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the query 2 raise Fail to serialize response
4 participants
@fzhedu @ti-srebot @zanmato1984 @windtalker