*: support Go1.11 module for release-2.1 #8432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Makefile vendor is still kept in this COMMIT, generated by 'go mod vendor' github.com/pkg/errors is changed to github.com/pingcap/errors github.com/pingcap/tidb-tools is updated github.com/pkg/errors is indirect from pd many files are deleted from vendor, maybe they are detected useless
|
/run-all-tests tidb-test=release-2.1 |
tiancaiamao
added
the
priority/release-blocker
|
/run-all-tests tidb-test=pr/663 |
|
/common-test tidb-test=pr/663 |
|
/run-all-tests tidb-test=pr/663 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As the title says...
It can't be cherry pick, so I rewrite
What is changed and how it works?
Related changes
#7922
#8136
#8054
This change is