Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go1.11 module #7922

Closed
tiancaiamao opened this issue Oct 16, 2018 · 1 comment · Fixed by #8054
Closed

Support Go1.11 module #7922

tiancaiamao opened this issue Oct 16, 2018 · 1 comment · Fixed by #8054
Assignees
Labels

Comments

@tiancaiamao
Copy link
Contributor

Feature Request

Go 1.11 introduce module, and it's the standard way for package dependency management.
Support module in TiDB may helpful, for example, #7884 can be fixed.
We'll also benefit from Go module that people will be able to use go get for the TiDB binary.

However, it's not a trivial work to support module.
The biggest problem is parser, as I've point out in #7494
parser.go is generated using make parser, this can't be handled by go module.

We can put generated parser.go in the repository directly, rather than generate it using Makefile script.
The drawback of this way is that every time parser.y is touched, there will be many lines change in parser.go. Then the TiDB repo will be inflate quickly.

A better way is moving parser to a separated repo, so every time parser is changed, only go.mod need to change accordingly.

@tiancaiamao
Copy link
Contributor Author

I find gofail can't work properly with module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant